Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Rank Feature #11

Merged
merged 10 commits into from
Oct 20, 2023
Merged

Added Rank Feature #11

merged 10 commits into from
Oct 20, 2023

Conversation

tanmaypardeshi
Copy link
Owner

Add participation tracking as well as ranking of users based on participation

Copy link
Collaborator

@ExtremeMachine12 ExtremeMachine12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good but maybe add some comments and fix the pylint errors.

@codecov-commenter
Copy link

Codecov Report

Merging #11 (a3cfcce) into main (e904165) will decrease coverage by 2.22%.
Report is 24 commits behind head on main.
The diff coverage is 12.69%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
- Coverage   62.47%   60.25%   -2.22%     
==========================================
  Files          13       14       +1     
  Lines        1351     1409      +58     
==========================================
+ Hits          844      849       +5     
- Misses        507      560      +53     
Files Coverage Δ
src/rank_card.py 13.33% <13.33%> (ø)
src/bot.py 56.46% <12.50%> (-4.57%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Collaborator

@ExtremeMachine12 ExtremeMachine12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@ExtremeMachine12 ExtremeMachine12 merged commit 8e179f4 into main Oct 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants