bugfix/variable tokens eval #134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion. Added toast notifications upon failed request execution. Added initial hover tooltip upon variables.
Updated the variable parsing and caching to support secrets evaluation. Added support for \n and & delimiters for $ prefixed variables.
|
@tanhakabir Hello! Can you review this PR, please :)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve variable evaluations, this change adds support for curly brackets evaluation.
It can be used several times inside the URL, headers or body of a request since it is parsed through regex groups.
Also, an initial Hover over variables will display the variable content if it was already processed.
Some of the caching and variable extraction was moved from the request.ts into a new dedicated class. Since the Hover doesn't have context of the request nor the Notebook cell (only the code document of the cell being hovered), the variable parser is a singleton and so lives through executed requests and the session of the file.
This part can probably be improved.