Fixes for Visual Studio. #12
Conversation
lygstate
force-pushed
the
tangram
branch
2 times, most recently
from
a7cff7a to
e77f26a
Compare
|
I realized that we don't actually have an easy way to test Windows builds, so I created an Appveyor build script in another PR: #13 The Appveyor build currently fails, so it seems like these fixes are needed! Once the Appveyor script is merged, this branch should be rebased on top of it so that these changes will be built on Appveyor. |
|
Merged the Appveyor script - @lygstate can you rebase onto the newest commit on the |
|
@lygstate thanks for working on the Windows build! For the exp matchers I think we can remove all the |
# Conflicts: # include/yaml-cpp/node/detail/node.h # include/yaml-cpp/node/impl.h # include/yaml-cpp/node/ptr.h # src/exp.h # src/simplekey.cpp
|
The appveyor is not valid, I'll submit a valid version later. |
|
Oh I see, the Appveyor script failed to run the tests. The test runner is an executable at the path |
|
ctest is enough to do the tests see my changes |
|
You're right, ctest seems to work! Thanks. @hjanetzek you had suggestions for the matcher templates - can you add your suggestions to the PR or create a patch to try? |
|
@lygstate the changes you made to plalloc leak all memory. For now I would just disable the pooling with MSVC unless you want to work on it. |
|
@hjanetzek Thanks, that's OK. |
No description provided.