Change generated polygon centroids label_placement to match vector tiles 1.0

[bcamper]

When we release Mapzen vector tiles 1.0, we should change our synthesized polygon centroid features (enabled with generate_label_centroids on GeoJSON/TopoJSON sources) to match the new terminology:

Instead of label_placement = yes, it is now label_placement = true.

[nvkelso]

👍

[dmvaldman]

I can change this. Should we accept both true and "yes" for backwards compatibility with a depreciation warning thrown when "yes" is used? Or just peel the bandaid off all at once?

[bcamper]

Hmm, accepting both for backwards compatibility would be nice, but it would require special handling since this feature works by just generating new feature properties that are then filtered (with the filter) like any other... so it would need special-case code :/

We can probably get away with deprecating since this feature is not in heavy use yet.

[nvkelso]

• @burritojustice

On Aug 8, 2016, at 07:49, Brett Camper [email protected] wrote:

Hmm, accepting both for backwards compatibility would be nice, but it would require special handling since this feature works by just generating new feature properties that are then filtered (with the filter) like any other... so it would need special-case code :/

We can probably get away with deprecating since this feature is not in heavy use yet.

―
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

[burritojustice]

fine to rip off the bandaid, just a couple of instances (that I know) of that are easily changed.