Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android 12 system font support #2306

Merged
merged 3 commits into from
Nov 29, 2021
Merged

Android 12 system font support #2306

merged 3 commits into from
Nov 29, 2021

Conversation

matteblair
Copy link
Member

Resolves #2303

Despite the availability of a new SystemFonts API in Android API level 29 and above, it turned out to be easier and faster to modify the FontConfig XML parsing code to handle the format of fonts.xml in versions before and after Android 12. As mentioned in the issue though, we will still need to add support for font variation axes to render the bold or italic versions of many system fonts.

@matteblair matteblair merged commit 6e45c6f into main Nov 29, 2021
@matteblair matteblair deleted the android-font-upgrade branch November 29, 2021 10:01
@westnordost
Copy link
Contributor

With more and more people upgrading to Android 12, this is becoming more and more of a problem. My app has mostly users from the EU and US and I see now that 17% of users use Android 12, as opposed to 10% when the issue was first reported. As this is already fixed, are you planning to do a release soon?

Or were you waiting on feedback from the issue reporter or me whether the fix works correctly? I do have an Android 12 phone now, but I have no tangram-es development environment set up.

@rwrx
Copy link
Contributor

rwrx commented Jan 19, 2022

@westnordost I can confirm that it is fixed with this pull request.

@matteblair
Copy link
Member Author

I actually hadn't realized that this change had not been included in a release yet. I'll prioritize making a new release so that this becomes available to downstream users. Sorry to make you wait so long for this fix!

@KS-Balaji
Copy link

I have pulled this source. Now the fonts rendering was slow in some android 12 devices. @matteblair any ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No system fonts fallback on Android 12
4 participants