File System #17
Merged
File System #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rm-specific 'resources' folders
This is the simplest interface we can implement on both mobile platforms, but I don't like how unsafe it is (the caller has to manually deallocate the read buffer)
The AssetManager for the MainActivity must now be passed in on construction of the renderer
…to reference assets from the core project
Scope is now clarified as obtaining strings from internal resource files; OSX and iOS now both use Foundation functions to load a file into a string - It is tempting to share a platform file for OSX and iOS but but they will diverge again once input is implemented.
|
Don't merge; just discovered a bug on android. |
|
Good to merge! |
|
Looks good. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables read-only access to text files bundled with the application.
I chose to provide a function exclusively for text like shaders, config files, json, etc. because all of our other file needs will likely require significantly different (and possibly platform-specific) implementations. Textures should be loaded with Core Image on iOS (and maybe libpng on Android), cache files might use an SQL database (or maybe Core Storage on iOS); basically, I concluded that writing a totally general file I/O protocol would be a waste.
Also: I've converted the OS X platform file to objective-c++ because the Foundation framework makes file I/O really easy (and possibly faster). I see no downside to using objective-c where reasonable.