Implement repeat group logic for point based styles #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tallytalwar
force-pushed
the
point-repeats
branch
from
f31cb17 to
20dabd2
Compare
tallytalwar
force-pushed
the
point-repeats
branch
6 times, most recently
from
a58ca1e to
62f80a3
Compare
hjanetzek
approved these changes
Jan 19, 2017
tallytalwar
force-pushed
the
point-repeats
branch
from
62f80a3 to
0e7cbb1
Compare
karimnaaji
requested changes
Jan 23, 2017
| hash_combine(repeatGroupHash, repeatGroup); | ||
| } else { | ||
| repeatGroupHash = _rule.getParamSetHash(); | ||
| } |
There was a problem hiding this comment.
Should add
p.labelOptions.repeatDistance *= m_style.pixelScale();
around here.
There was a problem hiding this comment.
Oh no this is done later on.
karimnaaji
approved these changes
Jan 23, 2017
| hash_combine(repeatGroupHash, repeatGroup); | ||
| } else { | ||
| repeatGroupHash = _rule.getParamSetHash(); | ||
| } |
There was a problem hiding this comment.
Oh no this is done later on.
- fixes warning
- fix: repeat group should only be applied when repeat distance is > 0 - alter repeat group application for text based styles to accomodate inheritance logic from parent point style - implement repeat group and repeat distance parsing for point based styles - repeat distance is 0 by default for point based styles (unlike for text based styles, which has 256 as default repear distance)
karimnaaji
force-pushed
the
point-repeats
branch
from
0e7cbb1 to
52aec20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
point style
256 as default repeat distance)
Refer other details of the concept: tangrams/tangram#424
This PR branch is based on #1211