fix texture data race #1202
Merged
fix texture data race #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- don't clear textures directly in releaseAtlas. This could clear the atlas while it's used in layoutText, before the atlas ref count got updated.
tallytalwar
force-pushed
the
wip-fix-texture-data-race
branch
from
a72d4c5 to
abbeba1
Compare
tallytalwar
pushed a commit
that referenced
this pull request
Jan 11, 2017
* Lock on texture mutex when updating atlas reference counts * squash synchronize FontContext m_atlasRefs - don't clear textures directly in releaseAtlas. This could clear the atlas while it's used in layoutText, before the atlas ref count got updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync
m_atlasRefCountonm_textureMutex. I think this is important to go in soon.Don't clear textures directly in releaseAtlas. This could clear the atlas while it's used in layoutText, before the atlas ref count got updated.
Edit (Varun): Fixes #1196