More font loading speedups #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karimnaaji
force-pushed
the
reduce-font-data-copies
branch
6 times, most recently
from
1320448 to
7df4a33
Compare
karimnaaji
force-pushed
the
reduce-font-data-copies
branch
from
7df4a33 to
acc2579
Compare
|
@karimnaaji I think we could add a move constructor to |
|
Yeah we checked with @tallytalwar comparing data address to see if the RVO was actually propagating from the platform layer to alfons, but it would be worth to force the compiler to do that. |
hjanetzek
force-pushed
the
reduce-font-data-copies
branch
from
acc2579 to
269b567
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce data reinterpretation between platform layer and alfons.
Moving from a total of 946.282ms to 425.619ms on iPhone 6s, other platforms need to be updated.