Okhttp 3.5 #1171
Merged
Okhttp 3.5 #1171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tallytalwar
force-pushed
the
okhttp-3.5
branch
from
b6a9af8 to
951eb53
Compare
ecgreb
reviewed
Dec 20, 2016
There was a problem hiding this comment.
Changes look good to me although I have not tested or tried to upgrade to okhttp3 in other libs as of yet.
I'm going to work on updating in https://github.com/pelias/pelias-android-sdk and https://github.com/mapzen/on-the-road_android.
May have additional comments depending on how that goes.
matteblair
force-pushed
the
okhttp-3.5
branch
from
951eb53 to
3c16542
Compare
matteblair
approved these changes
Dec 22, 2016
ecgreb
approved these changes
Jan 3, 2017
This is an API breaking change. - Removed HttpHandler::setCache - Adds a parameterized constructor to set HttpHandler cache
response provides a way to get raw bytes now.
- Delegate default constructor - Compare URL string instead of 'tag' for cancellation - onCancel cancels all calls with the given URL, in case more than one does
tallytalwar
force-pushed
the
okhttp-3.5
branch
from
3c16542 to
4bead5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were 1 full version behind with OKHTTP. We have been using Okhttp2.5, while they have released some major upgrades to their library. This PR moves us to latest and greatest from OKHttp.
Note: This is an API breaking change.
HttpHandlerdoes not have asetCachemethod. A new parameterized constructor is added toHttpHandlerto set the cache. This is because of the API change(s) in OkHttp3.0 and beyond.