Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

old: Texture dots #33

Open
wants to merge 8 commits into
base: gh-pages
Choose a base branch
from
Open

old: Texture dots #33

wants to merge 8 commits into from

Conversation

patriciogonzalezvivo
Copy link
Contributor

Adding a sdf-shape that could be reused for other styles. How it works?

  • takes a SDF texture u_sdf
  • which can be transform into a fill or stroke shape
  • I replace the previous circle function with it

We now can do more complex patterns if we want : )

@bcamper
Copy link
Member

bcamper commented Dec 14, 2016

Notes from discussion with @patriciogonzalezvivo:

  • Use a smaller dot texture, this one is quite big (78k), and I doubt the resolution is needed
  • Let's not include non-production files like the shader used to generate the dot. It's useful to save, but my goal is to have the bundler just be zip (e.g. not require any special bundling script that has to fetch additional files or exclude others).

@matteblair
Copy link
Member

You could put the 'brick' tiling pattern into the SDF texture as well, to further simplify the shader!

@patriciogonzalezvivo
Copy link
Contributor Author

Yes @blair1618 ! that's next on my TODO... I will wait for this PR to merge so I don't introduce a lot of changes at once. cc @nvkelso @bcamper @sensescape

@patriciogonzalezvivo
Copy link
Contributor Author

@nvkelso @bcamper can we merge this?

…s before refactor

tiny-dots are not showing up, force them to be medium in the mean time
@nvkelso
Copy link
Member

nvkelso commented Dec 28, 2016

@patriciogonzalezvivo can you help @sensescape and I debug why tiny-dots: don't show up at all? This is affecting landuse styles like cemetery and garden. We've set them to medium-dots in the meantime.

@patriciogonzalezvivo
Copy link
Contributor Author

hi @nvkelso, not sure what you need. seams like an old PR that wasn't merge

@nvkelso nvkelso changed the title Texture dots old: Texture dots Jun 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants