Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Set properties when starting a local testnet #317

Merged
merged 2 commits into from
Mar 28, 2023
Merged

[chore] Set properties when starting a local testnet #317

merged 2 commits into from
Mar 28, 2023

Conversation

Nutomic
Copy link
Contributor

@Nutomic Nutomic commented Mar 28, 2023

Summary of changes
Changes introduced in this pull request:

  • I wasnt getting any properties in relayer tests, because it starts the substrate node with local testnet config. So this config should also set the same properties.

Reference issue to close (if applicable)

Required for tangle-network/relayer#375

shekohex
shekohex approved these changes Mar 28, 2023
View reviewed changes
Copy link
Collaborator

@shekohex shekohex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@shekohex shekohex changed the title Also set properties when starting local testnet [chore] Set properties when starting a local testnet Mar 28, 2023
@shekohex shekohex merged commit 0f31564 into main Mar 28, 2023
@shekohex shekohex deleted the felix/local-testnet-properties branch March 28, 2023 15:15
1xstj pushed a commit that referenced this pull request Mar 31, 2023
@Nutomic @akileshtangella @1xstj
[chore] Set properties when starting a local testnet (#317)
d8e569e 
Co-authored-by: Akilesh Tangella <[email protected]>
1xstj added a commit that referenced this pull request Mar 31, 2023
@1xstj @Nutomic @akileshtangella
bump to polkadot-v0.9.39 (#318)
05a69fe 
* update 0.9.39

* Change token decimals to 18 (#316)

* [chore] Set properties when starting a local testnet (#317)

Co-authored-by: Akilesh Tangella <[email protected]>

* fix type conflicts

* fix tests

* fix branch

* fix branch

---------

Co-authored-by: Nutomic <[email protected]>
Co-authored-by: Akilesh Tangella <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shekohex shekohex shekohex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nutomic @shekohex @akileshtangella