add reward pallet modifications #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwhuo68
requested review from
akileshtangella,
drewstone,
semaraugusto and
1xstj
|
@saiakilesh good to merge if you review and give it the go ahead. |
There was a problem hiding this comment.
Along, with my comments on specific lines of code, here are a few overarching things:
- We have renamed things:
DepositTree->UnspentTree,WithdrawTree -> SpentTree. - I would rather separate concerns and have two different pallets, a claims pallet and an AMM pallet. The claims pallet is responsible for storing reward tree roots, checking claims circuit proof, and inserting commitments into the AP VAnchor. The AMM pallet is responsible for converting AP into Tangle tokens (or whatever the reward token is).
akileshtangella
suggested changes
Feb 14, 2023
drewstone
requested review from
akileshtangella
and removed request for
drewstone and
semaraugusto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
-Scaffold for pallet modifications for rewards (AP VAnchor updating, etc)