support multi-schema-change for drop index #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defined2014
reviewed
Mar 14, 2022
| // Move all the dependent hidden columns to the end. | ||
| endOffset := len(tblInfo.Columns) - 1 | ||
| for _, offset := range hiddenColOffs { | ||
| tblInfo.MoveColumnInfo(offset, endOffset) |
There was a problem hiding this comment.
Suggested change
| tblInfo.MoveColumnInfo(offset, endOffset) | |
| tblInfo.MoveColumnInfo(offset, endOffset) | |
| endOffset-- |
There was a problem hiding this comment.
I think the order does not matter, because the columns will be removed anyway.
There was a problem hiding this comment.
It will reduce the number of exchanges
Defined2014
reviewed
Mar 14, 2022
Defined2014
reviewed
Mar 14, 2022
Defined2014
reviewed
Mar 14, 2022
Defined2014
reviewed
Mar 14, 2022
tangenta
force-pushed
the
msc-drop-index
branch
from
26aba4f to
15153a0
Compare
tangenta
commented
Mar 14, 2022
| @@ -217,6 +217,9 @@ func onAddColumn(d *ddlCtx, t *meta.Meta, job *model.Job) (ver int64, err error) | |||
| } | |||
|
|
|||
| func locateOffsetForColumn(pos *ast.ColumnPosition, tblInfo *model.TableInfo) (offset int, err error) { | |||
| if pos == nil { | |||
| return -1, nil | |||
| } | |||
There was a problem hiding this comment.
locateOffsetForColumn is also used by AddColumn so the pos can be null.
tangenta
commented
Mar 14, 2022
| @@ -362,7 +365,7 @@ func onAddColumns(d *ddlCtx, t *meta.Meta, job *model.Job) (ver int64, err error | |||
| case model.StateWriteReorganization: | |||
| // reorganization -> public | |||
| // Adjust table column offsets. | |||
| for i, newCol := range tblInfo.Columns[:len(tblInfo.Columns)-len(positions)] { | |||
| for i, newCol := range tblInfo.Columns[len(tblInfo.Columns)-len(positions):] { | |||
There was a problem hiding this comment.
Added test in TestMultiSchemaChangeAddColumns:
create table t (a int, b int, c int);
alter table t add column (d int default 4, e int default 5);
Defined2014
approved these changes
Mar 14, 2022
tangenta
added a commit
that referenced
this pull request
Aug 22, 2022
tangenta
pushed a commit
that referenced
this pull request
Jul 17, 2023
make system variables take effects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #21
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note