Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(books): implement defaultAsset expand #117

Merged
merged 6 commits into from
Aug 5, 2024
Merged

feat(books): implement defaultAsset expand #117

merged 6 commits into from
Aug 5, 2024

Conversation

catouberos
Copy link
Contributor

No description provided.

@catouberos catouberos added the enhancement New feature or request label Aug 5, 2024
@catouberos catouberos requested a review from momo-p August 5, 2024 09:52
@catouberos catouberos self-assigned this Aug 5, 2024
momo-p
momo-p requested changes Aug 5, 2024
View reviewed changes
models/asset.go Outdated Show resolved Hide resolved
models/asset.go Outdated Show resolved Hide resolved
@momo-p
Copy link
Contributor

momo-p commented Aug 5, 2024

Maybe change the Book#DefaultAsset() to Book#GetRoot()#Asset() too

@catouberos catouberos requested a review from momo-p August 5, 2024 14:52
@momo-p momo-p changed the title feat(books)!: implement defaultAsset expand feat(books): implement defaultAsset expand Aug 5, 2024
@momo-p momo-p merged commit 4b5baaf into master Aug 5, 2024
1 check passed
@momo-p momo-p deleted the catou/books-assets branch August 5, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@momo-p momo-p momo-p approved these changes

Assignees

@catouberos catouberos

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@catouberos @momo-p