Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle LSP shutdown request #354

Merged
merged 1 commit into from
May 15, 2023
Merged

Conversation

the-mikedavis
Copy link
Contributor

These lines in the Server loop discard any messages with the shutdown method. The Server can handle and correctly respond to shutdown requests, though, so there's no need to discard the message.

These lines in the Server loop discard any messages with the shutdown
method. The Server can handle and correctly respond to shutdown
requests, though, so there's no need to discard the message.
@David-Else
Copy link

@tamasfe Sorry to ping you, but is there any time line estimate regarding getting this merged and released? The long delay on closing Helix on a daily basis is spoiling the experience of an otherwise awesome language server.

@tamasfe
Copy link
Owner

tamasfe commented Jan 25, 2023

Hi @David-Else, sorry about the silence, I currently don't have a lot of spare time/mental capacity. I'll try to catch up with the things here next weekend.

@cyqsimon
Copy link

cyqsimon commented Feb 14, 2023

Hi @David-Else, sorry about the silence, I currently don't have a lot of spare time/mental capacity. I'll try to catch up with the things here next weekend.

Any hopes we can see this merged soon? It's a very small change after all, but a very important one.

Also no offense, but in your absence can you please consider adding a few collaborators, so that issues and PRs don't pile up and progress can be made? Much thanks.

@ia0
Copy link
Collaborator

ia0 commented May 1, 2023

I upvote the need for collaborators (if there are any volunteers).

I'm a bit worried about this project when I see that:

  • This (seemingly simple, but I might be wrong) bug fix has been open for 5 months.
  • This is the only PR (out of 13 currently open) with upvotes. And it has 21 upvotes (which I suspect is a non-negligible proportion of the taplo userbase).
  • The request for collaborators was not acknowledged for 2 months (I understand it takes time to find trustworthy collaborators, but communication on being open for collaboration is already a good signal).
  • The last merged PR is 5 months old (that could mean the project is stable though, but this is not completely the case here).

I hope this is only a transitory period and the project has a bright future.

@swand0g
Copy link

swand0g commented May 1, 2023

i upvote the need for collaborators (if there are any volunteers).

yea that or forking might be the move pretty soon

@ia0
Copy link
Collaborator

ia0 commented May 4, 2023

Actually there's #403 which seems to predate the latest comments, not sure how I missed it. I'm watching the whole repository now to not miss notifications.

ahirner added a commit to ahirner/nix-trickle that referenced this pull request May 6, 2023
ahirner added a commit to ahirner/nix-trickle that referenced this pull request May 6, 2023
@ia0 ia0 mentioned this pull request May 15, 2023
@panekj panekj merged commit 7d8b8a5 into tamasfe:master May 15, 2023
@the-mikedavis the-mikedavis deleted the md-handle-shutdown branch May 15, 2023 22:00
@elenakrittik
Copy link

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants