-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle LSP shutdown request #354
Conversation
These lines in the Server loop discard any messages with the shutdown method. The Server can handle and correctly respond to shutdown requests, though, so there's no need to discard the message.
@tamasfe Sorry to ping you, but is there any time line estimate regarding getting this merged and released? The long delay on closing Helix on a daily basis is spoiling the experience of an otherwise awesome language server. |
Hi @David-Else, sorry about the silence, I currently don't have a lot of spare time/mental capacity. I'll try to catch up with the things here next weekend. |
Any hopes we can see this merged soon? It's a very small change after all, but a very important one. Also no offense, but in your absence can you please consider adding a few collaborators, so that issues and PRs don't pile up and progress can be made? Much thanks. |
I upvote the need for collaborators (if there are any volunteers). I'm a bit worried about this project when I see that:
I hope this is only a transitory period and the project has a bright future. |
yea that or forking might be the move pretty soon |
Actually there's #403 which seems to predate the latest comments, not sure how I missed it. I'm watching the whole repository now to not miss notifications. |
thanks! |
These lines in the Server loop discard any messages with the shutdown method. The Server can handle and correctly respond to shutdown requests, though, so there's no need to discard the message.