Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added rich text formatting in instructions #28

Merged
merged 7 commits into from
Sep 4, 2023
Merged

added rich text formatting in instructions #28

merged 7 commits into from
Sep 4, 2023

Conversation

rohansharmasitoula
Copy link
Contributor

@rohansharmasitoula rohansharmasitoula commented Aug 29, 2023 •
edited
Loading

Description

  • added rich text formatting in instruction component

Github Issue

Checklist before requesting a review

  • One line description of the changes is added in the PR
  • Issue is linked to the PR via commits (eg: resolves #123)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires only a documentation update

@rohansharmasitoula rohansharmasitoula self-assigned this Aug 29, 2023
@rohansharmasitoula rohansharmasitoula linked an issue Aug 29, 2023 that may be closed by this pull request
Feature: Add Rich text formatting in insturctions component #27
Closed
@rohansharmasitoula rohansharmasitoula changed the base branch from release/v1.1.1 to release/v1.2.0 August 29, 2023 18:03
@devang1281
Copy link
Collaborator

As per @rohansharmasitoula 's discussion with @rakeshprabhu , We are going ahead with "https://cdn.ckeditor.com/4.22.1/standard/ckeditor.js" richtexteditor instead of moodle's inbuilt richtexteditor

devang1281
devang1281 approved these changes Sep 4, 2023
View reviewed changes
Copy link
Collaborator

@devang1281 devang1281 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devang1281 devang1281 merged commit 515083b into release/v1.2.0 Sep 4, 2023
1 check passed
@devang1281 devang1281 deleted the rich_text_format_in_instructions branch September 4, 2023 06:50
@manquer manquer removed their request for review September 9, 2023 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devang1281 devang1281 devang1281 approved these changes

@rakeshprabhu rakeshprabhu Awaiting requested review from rakeshprabhu rakeshprabhu is a code owner

@harish-talview harish-talview Awaiting requested review from harish-talview harish-talview is a code owner

@merlano17 merlano17 Awaiting requested review from merlano17 merlano17 is a code owner

@KeerthiHarish KeerthiHarish Awaiting requested review from KeerthiHarish KeerthiHarish is a code owner

Assignees

@rohansharmasitoula rohansharmasitoula

Labels
Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Add Rich text formatting in insturctions component
2 participants
@rohansharmasitoula @devang1281