Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert keys to .talon-list where possible #1554

Merged
merged 10 commits into from
Oct 5, 2024
Merged

Conversation

knausj85
Copy link
Member

@knausj85 knausj85 commented Sep 1, 2024

  • does not port punctuation_words or symbol_keys, as these are used by create spoken forms
  • adds support for keypad keys

knausj85 and others added 2 commits August 31, 2024 18:51
- does not port punctuation_words or symbol_keys, as these are used by create spoken forms
- add support for keypad keys
@knausj85
Copy link
Member Author

knausj85 commented Sep 1, 2024

We discussed the old PR (940fe69) a bit in the backlog session. The thinking is to avoid trying to create some sort of auto-conversion mechanism and live with a manual merge for python lists we convert to *.talon-list.

Copy link
Collaborator

@AndreasArvidsson AndreasArvidsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably leave a link to the wiki in letters and modifier lists

@nriley
Copy link
Collaborator

nriley commented Sep 7, 2024

https://talon.wiki/Quickstart/improving_recognition_accuracy#collected-alternatives-to-the-default-alphabet is for the alphabet; we should migrate our recommended modifier alternatives to the wiki too.

@knausj85
Copy link
Member Author

knausj85 commented Sep 7, 2024

Since the modifiers aren't already on the wiki, maybe we save that bit for another day. I think this is good to go.

core/keys/keys.py Outdated Show resolved Hide resolved
core/keys/keys.py Show resolved Hide resolved
@nriley
Copy link
Collaborator

nriley commented Sep 7, 2024

Since the modifiers aren't already on the wiki, maybe we save that bit for another day. I think this is good to go.

Heh, I didn't see this before I put together a wiki change :-) Let me know if you want some other alternatives; I included the ones from the comments plus the ones I use personally.

https://github.com/TalonCommunity/Wiki/pull/302/files#diff-6eb918b959893584905f667cd9806ebf3f89362a8ecf3534138f985d80236fc2R92

Fix description
@knausj85
Copy link
Member Author

knausj85 commented Sep 8, 2024

Since the modifiers aren't already on the wiki, maybe we save that bit for another day. I think this is good to go.

Heh, I didn't see this before I put together a wiki change :-) Let me know if you want some other alternatives; I included the ones from the comments plus the ones I use personally.

https://github.com/TalonCommunity/Wiki/pull/302/files#diff-6eb918b959893584905f667cd9806ebf3f89362a8ecf3534138f985d80236fc2R92

Those look good to me, thanks. Forgot I'm a member over on the wiki org too, and can do things 🐙

@nriley nriley self-requested a review October 5, 2024 16:37
@nriley nriley merged commit df82aac into main Oct 5, 2024
2 checks passed
@nriley nriley deleted the new-keys-to-talon-list branch October 5, 2024 16:39
nriley added a commit to nriley/talon_community that referenced this pull request Oct 6, 2024
@nriley
Copy link
Collaborator

nriley commented Oct 7, 2024

Ugh, we missed 'insert" too...

nriley added a commit to nriley/talon_community that referenced this pull request Oct 12, 2024
All platforms:
- keypad_enter
- insert (inadvertently removed in talonhub#1554)
- Allow dictating keypad keys directly without "press"

Mac:
- "function"/"globe" for globe/fn modifier (increasingly used by the OS)
- "return" for return (as printed on Apple keyboards)
- "enter" for [keypad] enter

The only one I'm a bit worried about is the last one. It does behave "correctly" per Apple's definitions but it's possible some users are used to saying "enter" (though it's not the correct name for the key) and will get unexpected behavior.
phillco pushed a commit that referenced this pull request Oct 19, 2024
All platforms:
- keypad_enter
- insert (inadvertently removed in #1554)
- Allow dictating keypad keys directly without "press"

Mac:
- "function"/"globe" for globe/fn modifier (increasingly used by the OS)
- "return" for return (as printed on Apple keyboards)
- "enter" for [keypad] enter

The only one I'm a bit worried about is the last one. It is correct per
Apple's definitions but it's possible some users are used to saying
"enter" (though it's not the correct name for the key) and will get
unexpected behavior; in most Mac apps I've tried, Return and Enter
behave identically.

Co-authored-by: Jeff Knaus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants