-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert keys to .talon-list where possible #1554
Conversation
knausj85
commented
Sep 1, 2024
- does not port punctuation_words or symbol_keys, as these are used by create spoken forms
- adds support for keypad keys
- does not port punctuation_words or symbol_keys, as these are used by create spoken forms - add support for keypad keys
for more information, see https://pre-commit.ci
We discussed the old PR (940fe69) a bit in the backlog session. The thinking is to avoid trying to create some sort of auto-conversion mechanism and live with a manual merge for python lists we convert to *.talon-list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably leave a link to the wiki in letters and modifier lists
https://talon.wiki/Quickstart/improving_recognition_accuracy#collected-alternatives-to-the-default-alphabet is for the alphabet; we should migrate our recommended modifier alternatives to the wiki too. |
Since the modifiers aren't already on the wiki, maybe we save that bit for another day. I think this is good to go. |
Mo branches, mo problems
for more information, see https://pre-commit.ci
Heh, I didn't see this before I put together a wiki change :-) Let me know if you want some other alternatives; I included the ones from the comments plus the ones I use personally. |
Fix description
Those look good to me, thanks. Forgot I'm a member over on the wiki org too, and can do things 🐙 |
Ugh, we missed 'insert" too... |
All platforms: - keypad_enter - insert (inadvertently removed in talonhub#1554) - Allow dictating keypad keys directly without "press" Mac: - "function"/"globe" for globe/fn modifier (increasingly used by the OS) - "return" for return (as printed on Apple keyboards) - "enter" for [keypad] enter The only one I'm a bit worried about is the last one. It does behave "correctly" per Apple's definitions but it's possible some users are used to saying "enter" (though it's not the correct name for the key) and will get unexpected behavior.
All platforms: - keypad_enter - insert (inadvertently removed in #1554) - Allow dictating keypad keys directly without "press" Mac: - "function"/"globe" for globe/fn modifier (increasingly used by the OS) - "return" for return (as printed on Apple keyboards) - "enter" for [keypad] enter The only one I'm a bit worried about is the last one. It is correct per Apple's definitions but it's possible some users are used to saying "enter" (though it's not the correct name for the key) and will get unexpected behavior; in most Mac apps I've tried, Return and Enter behave identically. Co-authored-by: Jeff Knaus <[email protected]>