-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(3c -> 3b) Add method to test instance grouping #1599
Merged
roomrys
merged 9 commits into
liezl/add-method-to-get-single-instance-permutations
from
liezl/add-method-to-test-instance-grouping
Jan 20, 2024
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
b9af5c3
Add method and (failing) test to get instance grouping
d89adff
Rename functions and add a per instance error function
2fbaf1f
Merge branch 'liezl/add-method-to-get-single-instance-permutations' o…
f7fd938
Update tests to accept a dummy instance
8b73638
Merge branch 'liezl/add-method-to-get-single-instance-permutations' o…
c5001ea
Rename last few permutations to products
892863b
Merge branch 'liezl/add-method-to-get-single-instance-permutations' o…
roomrys 1b21838
Typehinting
roomrys ed27d88
(3d -> 3c) Add method for multi instance products (#1605)
roomrys File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The method
calculate_reprojection_per_frame
calculates the reprojection error for each frame, which seems correct. However, there are a few points to consider:np.nan_to_num
in line 3790 may mask potential issues with the data. If NaN values are expected and normal, this is fine, but if they indicate a problem with the data or computation, it might be better to handle them explicitly.instance_error
in line 3791 does not square the difference before taking the norm, which is typical in reprojection error calculations. If the intention is to calculate the Euclidean distance, this is correct. Otherwise, consider squaring the differences.np.linalg.norm
function is the correct choice for calculating the instance error. If you're looking for a sum of squared differences, you might need to square thenode_errors
before summing.instances_in_view
. If there are no instances in view for a particular camera, this could lead to a division by zero or other unexpected behavior when calculating averages or normalizing errors.