Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More updates to Node.js example code #565

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

keerlu
Copy link
Contributor

@keerlu keerlu commented Jan 8, 2025

Some more updates to the example code that could do with another quick sanity check (sorry, should have waited until I finished the tutorial draft):

  • remove body-parser (deprecated) and use built-in Express parser
  • include welcomeMessage in user data
  • make IDs strings
  • remove async defer from script import (seems a bit weird)

@keerlu keerlu requested a review from csmeyns January 8, 2025 15:00
Copy link
Contributor

@csmeyns csmeyns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, helpful changes, these indeed make it yet clearer and cleaner 🙂 (just for completeness: I didn't test it out from scratch this time but have read through the changes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants