Skip to content
This repository has been archived by the owner on Sep 13, 2018. It is now read-only.

Implement Shop UI #3

Open
Ablu opened this issue Nov 9, 2014 · 8 comments
Open

Implement Shop UI #3

Ablu opened this issue Nov 9, 2014 · 8 comments
Assignees
Milestone

Comments

@Ablu
Copy link
Member

Ablu commented Nov 9, 2014

Currently the shop ui is lacking while the code in behind is there in theory.

@Ablu Ablu added this to the 0.1.0 milestone Nov 9, 2014
@Ablu
Copy link
Member Author

Ablu commented Nov 13, 2014

@bjorn: Did you had any ideas on how shop interaction could work?

What do you think about a temporary tab in the left side panel which has the shop contents. Tapping an entry could expand the item and show detailed info about the effect of the item (description, attribute modifiers, ...). For non-stackable items it could then show a buy button and for stackable ones a slider with an selectable amount + buy button.

Any other ideas?

@bjorn
Copy link
Member

bjorn commented Nov 13, 2014

Your suggestions sound fine to me.

@Ablu Ablu self-assigned this Dec 20, 2014
@Ablu
Copy link
Member Author

Ablu commented Dec 20, 2014

Does the buy limit really make any sense?

I mean the item amount in http://doc.manasource.org/scripting.html#trade?
I mean you can just close the trade and make a new one and have all items again...

@bjorn
Copy link
Member

bjorn commented Dec 20, 2014

@Ablu While it is true that currently you can just reopen the shop to reset the buyable amounts, I imagine the purpose of this was to be able to handle shops with a persistent inventory. Though of course, the current implementation is a long way from making that possible.

Actually having to reopen the shop does make abusing too low shop prices much more annoying at least...

@Ablu
Copy link
Member Author

Ablu commented Dec 20, 2014

I think for persistent shops we need some kind of global shared shop
which can update even while the player is having it open (so callbacks
on the server side can add and remove items).

On 12/20/2014 10:30 PM, Thorbjørn Lindeijer wrote:

@Ablu https://github.com/Ablu While it is true that currently you can
just reopen the shop to reset the buyable amounts, I imagine the purpose
of this was to be able to handle shops with a persistent inventory.
Though of course, the current implementation is a long way from making
that possible.

Actually having to reopen the shop does make abusing too low shop prices
much more annoying at least...


Reply to this email directly or view it on GitHub
#3 (comment).

@Ablu
Copy link
Member Author

Ablu commented Jun 15, 2015

The first part was merged. You can now at least buy stuff with a kind of presentable ui.

@Ablu
Copy link
Member Author

Ablu commented Jul 31, 2015

Is there any reason why we need the modes BuyFromShop and SellToShop as two different modes? Can't we simply allow selling and buying in the same mode?

@bjorn
Copy link
Member

bjorn commented Aug 1, 2015

I'd suggest we merge these modes as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants