Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds getsubscriptioninfo to the CLN plugin #86

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Adds getsubscriptioninfo to the CLN plugin #86

merged 1 commit into from
Aug 17, 2022

Conversation

sr-gi
Copy link
Member

@sr-gi sr-gi commented Aug 8, 2022

@sr-gi sr-gi added feature request New feature or request Seeking Code Review review me pls cln-plugin Stuff related to watchtower-plugin labels Aug 8, 2022
@sr-gi sr-gi added this to the v.0.1.2 milestone Aug 15, 2022
mariocynicys
mariocynicys requested changes Aug 15, 2022
View reviewed changes
Copy link
Collaborator

@mariocynicys mariocynicys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add some docs about this command in the watchtower plugin's readme.
LGTM otherwise.

@mariocynicys
Copy link
Collaborator

Also this should spell listtowers not list_towers. Can we fix it in the PR?

@sr-gi
Copy link
Member Author

sr-gi commented Aug 16, 2022

Also this should spell listtowers not list_towers. Can we fix it in the PR?

Sure, will squeeze it here

@sr-gi sr-gi force-pushed the cln-plugin-getsubscriptioninfo branch from 499ab13 to e671bbe Compare August 16, 2022 10:04
@sr-gi sr-gi force-pushed the cln-plugin-getsubscriptioninfo branch from e671bbe to d4a293f Compare August 16, 2022 10:41
@sr-gi
Copy link
Member Author

sr-gi commented Aug 16, 2022

@meryacine both issues should have been fixed in d4a293f

@sr-gi sr-gi mentioned this pull request Aug 16, 2022
Merged
mariocynicys
mariocynicys approved these changes Aug 16, 2022
View reviewed changes
Copy link
Collaborator

@mariocynicys mariocynicys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sr-gi sr-gi merged commit 33cd694 into talaia-labs:master Aug 17, 2022
@sr-gi sr-gi removed the Seeking Code Review review me pls label Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariocynicys mariocynicys mariocynicys approved these changes

Assignees
No one assigned
Labels
cln-plugin Stuff related to watchtower-plugin feature request New feature or request
Projects
None yet
Milestone
v.0.1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@sr-gi @mariocynicys