Simplifies the cln plugin option parsing

[sr-gi]

Options include helper functions to convert them to their proper type after
cln-plugin=0.1.2. Use that to reduce the option parsing boilerplate.

Also move all names, descriptions and default values for options, rpc_methods and hooks
to a new file.

[mariocynicys]

A couple of nits, all fine otherwise.

[mariocynicys]

nit: an empty line here.

[mariocynicys]

nit: host isn't quite the name for an HTTP url.
Also let's check .starts_with("http://") because a host name might actually start with http 😆.

[mariocynicys]

Ok now it makes sense why the PR's name is not very inclusive.
I think you included changes from #160 in here by mistake in 4c9141f.

[sr-gi]

Oh yeah, this is not pulling from master giving cln-plugin=0.1.2 is bumped in #160, and this PR builds on top of that.

This will need rebasing once #160 gets merged, but given it was double at this stage and didn't require much more I went ahead and fixed it.

[sr-gi]

Rebased and amended this so it pulls from master.

I've also moved a bit more data to constants.rs to reduce the hardcoded stuff in main.rs.

[sr-gi]

Rebased and amended this so it pulls from master.

I've also moved a bit more data to constants.rs to reduce the hardcoded stuff in main.rs.

Looks like I've broken the plugin by doing this 😅, not exactly sure why though.

[sr-gi]

Rebased and amended this so it pulls from master.
I've also moved a bit more data to constants.rs to reduce the hardcoded stuff in main.rs.

Looks like I've broken the plugin by doing this 😅, not exactly sure why though.

Fixed it, auto-retry-delay default value was beyond u16::MAX. Looks like this was not caught in 07caee2 because the default was set in two different places on the codebase:

rust-teos/watchtower-plugin/src/main.rs

Lines 544 to 547 in 07caee2

	)).option(ConfigOption::new(
	"watchtower-auto-retry-delay",
	Value::Integer(86400),
	"the time (in seconds) that a retrier will wait before auto-retrying a failed tower. Defaults to once a day",

rust-teos/watchtower-plugin/src/main.rs

Lines 625 to 629 in 07caee2

	if let Value::Integer(x) = midstate.option("watchtower-auto-retry-delay").unwrap() {
	x as u16
	} else {
	// We will never end up here, but we need to define an else. Should be fixed alongside the previous fixme.
	3600

[mariocynicys]

@sr-gi
One of the failures though wasn't in the e2e tests: https://github.com/talaia-labs/rust-teos/actions/runs/3884258978/jobs/6626583255

This panicked while checking if the retrier is idle. Guess the sleep time is too tight?

[sr-gi]

@sr-gi One of the failures though wasn't in the e2e tests: https://github.com/talaia-labs/rust-teos/actions/runs/3884258978/jobs/6626583255

This panicked while checking if the retrier is idle. Guess the sleep time is too tight?

That's my guess, unfortunately, I haven't been able to reproduce it locally