Adds named arguments to CoreLN plugin #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sr-gi
added
Seeking Code Review
sr-gi
force-pushed
the
cln-json-params
branch
3 times, most recently
from
59af17c to
ace7879
Compare
mariocynicys
requested changes
Dec 14, 2022
sr-gi
force-pushed
the
cln-json-params
branch
from
ace7879 to
7e97c9f
Compare
sr-gi
force-pushed
the
cln-json-params
branch
from
7e97c9f to
d0a476d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CoreLN supports named parameters for their RPC commands when passing
-kto the call. e.g:lightning-cli -k <command> arg_0=val_0...arg_n=val_nAdd support for our plugin so it's easier to tackle #69