Fix bind DOCKER_OPTS option (vdaas#2718)

* 🐛 Fix bind DOCKER_OPTS option Signed-off-by: vankichi <[email protected]> * Fix --------- Signed-off-by: vankichi <[email protected]>
takuyaymd · Dec 2, 2024 · dd5ebc6 · dd5ebc6
1 parent 677084a
commit dd5ebc6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/.github/workflows/dockers-example-client-image.yaml b/.github/workflows/dockers-example-client-image.yaml
@@ -73,5 +73,4 @@ jobs:
     uses: ./.github/workflows/_docker-image.yaml
     with:
       target: example-client
-      platforms: linux/amd64,linux/arm64
     secrets: inherit
diff --git a/Makefile.d/docker.mk b/Makefile.d/docker.mk
@@ -304,7 +304,7 @@ docker/name/loadtest:
 ## build loadtest image
 docker/build/loadtest:
 	@make DOCKERFILE="$(ROOTDIR)/dockers/tools/cli/loadtest/Dockerfile" \
-		DOCKER_OPTS="--build-arg ZLIB_VERSION=$(ZLIB_VERSION) --build-arg HDF5_VERSION=$(HDF5_VERSION)" \
+		DOCKER_OPTS="$${DOCKER_OPTS:+$${DOCKER_OPTS}} --build-arg ZLIB_VERSION=$(ZLIB_VERSION) --build-arg HDF4_VERSION=$(HDF5_VERSION)" \
 		IMAGE=$(LOADTEST_IMAGE) \
 		docker/build/image
 
@@ -372,7 +372,7 @@ docker/name/benchmark-job:
 docker/build/benchmark-job:
 	@make DOCKERFILE="$(ROOTDIR)/dockers/tools/benchmark/job/Dockerfile" \
 		IMAGE=$(BENCHMARK_JOB_IMAGE) \
-		DOCKER_OPTS="--build-arg ZLIB_VERSION=$(ZLIB_VERSION) --build-arg HDF5_VERSION=$(HDF5_VERSION)" \
+		DOCKER_OPTS="$${DOCKER_OPTS:+$${DOCKER_OPTS}} --build-arg ZLIB_VERSION=$(ZLIB_VERSION) --build-arg HDF4_VERSION=$(HDF5_VERSION)" \
 		docker/build/image
 
 .PHONY: docker/name/benchmark-operator
@@ -395,5 +395,5 @@ docker/name/example-client:
 docker/build/example-client:
 	@make DOCKERFILE="$(ROOTDIR)/dockers/example/client/Dockerfile" \
 		IMAGE=$(EXAMPLE_CLIENT_IMAGE) \
-		DOCKER_OPTS="--build-arg ZLIB_VERSION=$(ZLIB_VERSION) --build-arg HDF5_VERSION=$(HDF5_VERSION)" \
+		DOCKER_OPTS="$${DOCKER_OPTS:+$${DOCKER_OPTS}} --build-arg ZLIB_VERSION=$(ZLIB_VERSION) --build-arg HDF4_VERSION=$(HDF5_VERSION)" \
 		docker/build/image