Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DefaultAggregatorBuildContext test doesn't actually test if output is removed #15

Closed
virtuald opened this issue Nov 14, 2015 · 1 comment
Closed

DefaultAggregatorBuildContext test doesn't actually test if output is removed #15

virtuald opened this issue Nov 14, 2015 · 1 comment

Comments

@virtuald
Copy link
Contributor

See DefaultAggregatorBuildContextTest.java:93. It claims to remove the output file, but it actually removes an input file.

Removing an output file does work, but it's worth noting that it doesn't look like you have anything that actually tests it explicitly for the aggregator.
@ifedorenko
Copy link
Contributor

Are you asking about recreation of deleted aggregate output or about aggregate output cleanup when there is nothing to aggregate?

I don't have strong opinion about recreation of deleted aggregate outputs. If you feel strongly about it, please provide a unit test for the behaviour you expect.

Empty aggregate output cleanup, I am not sure either. Currently aggregate outputs are always created, but maybe there should be a flag to specify this.

DefaultAggregatorBuildContextTest.java:93 is a typo, need to change the comment to "removed input".

@virtuald virtuald mentioned this issue Nov 14, 2015
Merged
@atanasenko atanasenko mentioned this issue May 23, 2016
Open
prceasar pushed a commit that referenced this issue Feb 26, 2018
@Assk
Do not add any files not created/updated yet into output delta state (#…
6913836 
…15)

Adding output files preemptively to processed/modified output files list would
cause "No such file or directory" exceptions, if the file is not at all going
to be created after the builder execution.

Signed-off-by: Saravanakumar A. Srinivasan <[email protected]>
prceasar pushed a commit that referenced this issue Feb 27, 2018
@Assk @prceasar
Do not add any files not created/updated yet into output delta state (#…
9e91648 
…15)

Adding output files preemptively to processed/modified output files list would
cause "No such file or directory" exceptions, if the file is not at all going
to be created after the builder execution.

Signed-off-by: Saravanakumar A. Srinivasan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ifedorenko @virtuald