Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URLや電話番号をリンクに変換する #82

Merged
merged 1 commit into from
Jul 26, 2023
Merged

URLや電話番号をリンクに変換する #82

merged 1 commit into from
Jul 26, 2023

Conversation

naogify
Copy link
Collaborator

@naogify naogify commented Jun 28, 2023 •
edited
Loading

Close #78

  • 電話番号は 市外局番が省かれたもの（市内局番-加入者番号）は変換しないようにしています。（固定電話からしかかけられないため）
スクリーンショット 2023-06-28 15 28 41

@netlify
Copy link

netlify bot commented Jun 28, 2023 •
edited
Loading

✅ Deploy Preview for map-takamatsu-fact-com ready!

Name Link
🔨 Latest commit df66d61
🔍 Latest deploy log https://app.netlify.com/sites/map-takamatsu-fact-com/deploys/64a76a3c4e7f0400081a82db
😎 Deploy Preview https://deploy-preview-82--map-takamatsu-fact-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@naogify naogify requested a review from keichan34 June 28, 2023 06:29
keichan34
keichan34 requested changes Jun 28, 2023
View reviewed changes
Copy link
Collaborator

@keichan34 keichan34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

確認お願いします。

src/utils/replaceUrlToLink.ts Outdated Show resolved Hide resolved
src/SidebarDetail.tsx Outdated Show resolved Hide resolved
src/utils/replaceTelToLink.ts Outdated Show resolved Hide resolved
@naogify
Copy link
Collaborator Author

naogify commented Jul 5, 2023

@keichan34
こちら全ての value に対して、URLと電話番号（ハイフンあり・市外局番あり）のリンクへの変換をするようにしました。確認お願いしても良いでしょうか？

keichan34
keichan34 approved these changes Jul 6, 2023
View reviewed changes
Copy link
Collaborator

@keichan34 keichan34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございました！

@naogify
Copy link
Collaborator Author

naogify commented Jul 7, 2023

@takamatsu-toshiseibi
お世話になっております。Geolonia の大橋です。
電話番号とURLがデータにあった場合にリンクに変換する処理を追加しました。電話番号は市外局番付きの番号のみを変換するようにしています。（スマートフォンからの電話には市外局番が必要になるため）

問題ないようでしたら本番環境に反映しますので、お教えください。

プレビューURL
https://deploy-preview-82--map-takamatsu-fact-com.netlify.app/

スクリーンショット 2023-07-07 10 37 51

@naogify naogify merged commit cbbbcaf into main Jul 26, 2023
@naogify naogify deleted the add-link branch July 26, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keichan34 keichan34 keichan34 approved these changes

@takamatsu-toshiseibi takamatsu-toshiseibi Awaiting requested review from takamatsu-toshiseibi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

URLや電話番号をタップできるようにしてほしい。
2 participants
@naogify @keichan34