Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added RoborazziComposeActivityThemeOption #612

Merged
merged 5 commits into from
Dec 19, 2024

Conversation

pedromfmachado
Copy link
Contributor

@pedromfmachado pedromfmachado commented Dec 17, 2024

As discussed in #598, this PR introduces RoborazziComposeActivityThemeOption, allowing for the customisation of the test activity's theme.

@pedromfmachado pedromfmachado marked this pull request as ready for review December 17, 2024 15:00
Copy link

@takahirom
Copy link
Owner

Before 👀
image

@takahirom
Copy link
Owner

takahirom commented Dec 18, 2024

I'll check why the CI fails 👀

@pedromfmachado
Copy link
Contributor Author

pedromfmachado commented Dec 18, 2024

Thanks @takahirom, these changes help me get a better grasp of the project!

Added a couple of things that seemed to be missing:

  • The manifest declaration of RoborazziActivity which was needed by the tests within ComposeTest;
  • Considering createActivityScenarioOptions within the builder() method of RoborazziComposeOptions.

I hope this fixes the checks. 🙂

@takahirom
Copy link
Owner

Thank you for your contribution!

@takahirom takahirom merged commit 1ebc786 into takahirom:main Dec 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants