Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort key order of ComposePrintToString to stabilize output in Dump screenshots. #611

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

siarhei-luskanau
Copy link
Contributor

Dump screenshot has node properties. Sometime Roborazzi generates new screenshots (or fails verification) due the node properties order. This Pull Request add the output sorting to avoid the issue.

@siarhei-luskanau siarhei-luskanau changed the title Sort key order of ComposePrintToString to stabilize output in Dump sцreenshots. Sort key order of ComposePrintToString to stabilize output in Dump screenshots. Dec 16, 2024
Copy link
Owner

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!🔑

@takahirom takahirom merged commit ad3eb0c into takahirom:main Dec 16, 2024
7 checks passed
@siarhei-luskanau siarhei-luskanau deleted the sorted2 branch December 16, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants