Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update #2

Merged
merged 5 commits into from
Jun 26, 2024
Merged

update #2

merged 5 commits into from
Jun 26, 2024

Conversation

nishio
Copy link
Contributor

@nishio nishio commented Jun 25, 2024

No description provided.

Copy link
Member

@nanocloudx nanocloudx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

index.html については、ファイルサイズは肥大化してしまいますが、整形したものをコミットいただけると助かります!
(レビューのしやすさと、後々発生しうる微修正時の diff を確認しやすくする意図)

@@ -0,0 +1,25 @@
<!DOCTYPE html><html><head><meta charSet="utf-8"/><meta name="viewport" content="width=device-width"/><meta name="next-head-count" content="2"/><link rel="preload" href="./_next/static/css/1872bb4c65094a8a.css" as="style"/><link rel="stylesheet" href="./_next/static/css/1872bb4c65094a8a.css" data-n-g=""/><noscript data-n-css=""></noscript><script defer="" nomodule="" src="./_next/static/chunks/polyfills-78c92fac7aa8fdd8.js"></script><script src="./_next/static/chunks/webpack-6f0e0dcf15b6875d.js" defer=""></script><script src="./_next/static/chunks/framework-2c16ac744b6cdea6.js" defer=""></script><script src="./_next/static/chunks/main-be89c515900796e7.js" defer=""></script><script src="./_next/static/chunks/pages/_app-f73f9933f4da297d.js" defer=""></script><script src="./_next/static/chunks/3e199aef-45b2fc9d0ed295ef.js" defer=""></script><script src="./_next/static/chunks/781-fa124ba74309a0b8.js" defer=""></script><script src="./_next/static/chunks/664-fe029c8b38e64ec1.js" defer=""></script><script src="./_next/static/chunks/944-49ffdea2e7727a5a.js" defer=""></script><script src="./_next/static/chunks/pages/index-e17a209f4f723b29.js" defer=""></script><script src="./_next/static/D4Jm9jlcvDvWC2OHineDO/_buildManifest.js" defer=""></script><script src="./_next/static/D4Jm9jlcvDvWC2OHineDO/_ssgManifest.js" defer=""></script>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OGP 対応のため <head> タグは <head prefix="og: https://ogp.me/ns#"> とする必要があります

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

問題ないです!
が、他とのトンマナを揃える観点も多少なり必要と考えていますので、デザイナーへの依頼も検討したいですね

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

素材の背景画像を共有してください。それがないのでやりようがなくて困っています。

@nanocloudx nanocloudx self-requested a review June 26, 2024 02:35
Copy link
Member

@nanocloudx nanocloudx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nanocloudx nanocloudx merged commit fcad429 into takahiroanno2024:main Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants