Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please add React 19 as a peer dep #19

Closed
jasikpark opened this issue Dec 19, 2024 · 0 comments · Fixed by #20
Closed

Please add React 19 as a peer dep #19

jasikpark opened this issue Dec 19, 2024 · 0 comments · Fixed by #20

Comments

@jasikpark
Copy link
Contributor

jasikpark commented Dec 19, 2024 •
edited
Loading

Would appreciate an update adding React 19 as a peer dep: https://react.dev/blog/2024/12/05/react-19 💜

The implementation might be simpler in the future with direct React support for document metadata, including <title>: https://react.dev/blog/2024/12/05/react-19#support-for-metadata-tags

Docs: https://react.dev/reference/react-dom/components/title
jasikpark added a commit to jasikpark/react-titled that referenced this issue Dec 19, 2024
@jasikpark
Add React 19 as a peer dep
f6d26b8 
Fixes tajo#19 

Not sure if this library definitely works with React 19, but worth testing.
@jasikpark jasikpark mentioned this issue Dec 19, 2024
Merged
@IanVS IanVS closed this as completed in #20 Jan 3, 2025
@IanVS IanVS closed this as completed in e4cfabb Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add React 19 as a peer dep jasikpark/react-titled
1 participant
@jasikpark