Removable items by moving them out of bounds #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
tajo
commented
Jul 2, 2019
•
tajo
commented
gergelyke
approved these changes
Jul 2, 2019
chasestarr
reviewed
Jul 2, 2019
| } | ||
| return true; | ||
| } | ||
| if (this.state.itemDraggedOutOfBounds > -1) { |
There was a problem hiding this comment.
I was a bit unsure why state is reset here. calling isDraggedItemOutOfBounds a second time is required to get back to default? My first instinct would be to reset after this value is consumed. Interested to learn why this was positioned here
There was a problem hiding this comment.
isDraggedItemOutOfBounds is constantly called when an item is being moved around and then one more time when dropped. In both cases, this.state.isDraggedItemOutOfBounds can be reseted so that's why I put it directly into this method so it can be done only in one place.
There was a problem hiding this comment.
When an item is being moved around, it can be be flipped to > -1 and back multiple times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.