Add --noWatch option to serve command #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ecddd05 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Deploying with
|
| Latest commit: |
ecddd05
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d42dec7e.ladle.pages.dev |
| Branch Preview URL: | https://serve-no-watch.ladle.pages.dev |
chrisdothtml
approved these changes
Oct 10, 2023
tajo
reviewed
Oct 16, 2023
|
Lgtm. Just a type nitpick and the following documentation should be updated |
Merged
@chasestarr Looks like this was included in the v5 release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running in a multi tenant environment, we're seeing instances where chokidar exceeds the available
max_user_watches, with the error messageSystem limit for number of file watchers reached, watch 'src'. While we could increase that limit, there is no reason to watch the file system in this scenario. Making this change within ladle, rather than customizing throughvite.config.jsis important because ladle starts its own chokidar watch outside of vite.This PR adds a
--noWatchoption to the serve command to disable chokidar file system watching. It currently does this by adding all files to theignoredwatcher options. A recent PR to vite addednullas an acceptable value to achieve the same result, but it has not been included in a release yet. I added aTODOcomment in the code to update once available.