Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an e2e test about query parameters #521

Merged
merged 13 commits into from
Oct 4, 2023
Merged

Add an e2e test about query parameters #521

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8bf54ac
feat: Be usable non-ladle query params
cm-dyoshikawa Sep 23, 2023
e57058b
feat: move the query parameters example to e2e
cm-dyoshikawa Sep 25, 2023
2529d3e
Merge branch 'main' into feat-be-usable-non-ladle-query-params
cm-dyoshikawa Sep 25, 2023
5f6d6e3
Merge branch 'main' into feat-be-usable-non-ladle-query-params
cm-dyoshikawa Sep 25, 2023
540205a
fix: e2e tests
cm-dyoshikawa Sep 26, 2023
a3aaff2
add click the menu
cm-dyoshikawa Sep 26, 2023
bafb2b0
Merge branch 'main' into feat-be-usable-non-ladle-query-params
cm-dyoshikawa Sep 26, 2023
a887f61
Merge branch 'main' into feat-be-usable-non-ladle-query-params
cm-dyoshikawa Sep 27, 2023
7b52b91
Merge branch 'main' into feat-be-usable-non-ladle-query-params
cm-dyoshikawa Oct 2, 2023
e2a3ff9
Add resetParams to updateStory
cm-dyoshikawa Oct 2, 2023
1a26e5e
Add an e2e test to query parameters
cm-dyoshikawa Oct 4, 2023
51b6a60
Merge remote-tracking branch 'origin/main' into non-ladle-query-pamar…
cm-dyoshikawa Oct 4, 2023
379ae45
fix the test
cm-dyoshikawa Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions e2e/addons/tests/query-parameters.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,22 @@ test("when click the menu and open the story, remain non-ladle query parameters"
expect(url).toContain("foo=bar");
});

test("when move a story from the query parameters story, remove non-ladle query parameters", async ({
page,
}) => {
// Open the query parameters story
await page.goto("/?story=query-parameters--query-parameters");
await page.waitForSelector("[data-storyloaded]");

// Open a some story
await page.getByText("A11y").click();
await page.getByRole("link", { name: "Issues" }).click();
await page.waitForSelector("[data-storyloaded]");
const url = page.url();
expect(url).toContain("story=a11y--issues");
expect(url).not.toContain("foo=bar"); // The non-ladle query parameter is removed
});

test("preserve user query params after ladle query param update", async ({
page,
}) => {
Expand Down