Move important
selector to the front when @apply
-ing selector-modifying variants in custom utilities
#8313
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when given using an important selector (ex:
#myselector
), adding custom utilities to the utilities layer, using@apply
, and a class with a selector-modifying variant was applied we would put the selector in the wrong place — before the important selector. It's important to note that this behavior is correct for non-utility/user-defined CSS but is not correct for generated utilities.Now, when using
@layer utilities
or@layer components
and applying a class that modifies the selector — likegroup-hover:underline
— we now place the selector after the important selector when there is one.tl;dr:
Before:
After:
Fixes #8305