Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all color values from CSS Colors Level 4 spec #5154

Closed
wants to merge 5 commits into from

Conversation

htunnicliff
Copy link
Contributor

@htunnicliff htunnicliff commented Aug 5, 2021

@adamwathan in response to your ask that I include support for space-separated RGB values in addition to space-separated HSL values for #5003, I did some research.

I discovered several newer (well-maintained) color libraries that have full support for all color types used in the CSS Colors Level 4 spec.

As a result, I replaced the color library with culori instead. This supports both RGB and HSL colors with and without space-separated values, as well as all of these color spaces.

P.S.: Culori's API is quite robust, and as a result could support lots of cool future Tailwind color modification features, if desired 😄

Resolves #4677.

@htunnicliff
Copy link
Contributor Author

Hi @RobinMalfait and @bradlc 👋 – would you be able to take a look at this PR that improves Tailwind's support for newer CSS color formats?

I was chatting with @adamwathan about it in #5003 but it looks like he is not available at the present time.

@htunnicliff
Copy link
Contributor Author

Hey Tailwind team; following up here. It's been about two weeks since I submitted this PR. Is there something else I should do in order to receive a review?

@florianbouvot
Copy link
Contributor

@htunnicliff it's the holidays 😜

@RobinMalfait
Copy link
Member

Hey! Thank you for your PR!
Much appreciated! 🙏

I fixed the conflicts and merged it manually. Not sure why GitHub didn't mark this as merged, but your commits are there!

@danburzo
Copy link

danburzo commented Sep 1, 2021

Hi everyone. Happy to see this PR merged! The latest package version is [email protected] and includes things like parsing the color()syntax, which may be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alpha utilities do not apply to HSL colors using space-separated notation
4 participants