-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix media queries with jit and postcss7 #4078
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4078 +/- ##
==========================================
- Coverage 86.84% 86.83% -0.02%
==========================================
Files 341 341
Lines 4835 4838 +3
Branches 919 920 +1
==========================================
+ Hits 4199 4201 +2
- Misses 561 562 +1
Partials 75 75
Continue to review full report at Codecov.
|
Amazing, thank you! ❤️ |
Awesome work, thanks guys 👍 |
I still seem to have the same issue even after upgraded to 2.1.2. Using |
@dave-calleja I have the same issue. I'm using pinging @bradlc |
Hey! Please create a new issue and include a minimal reproduction, we don't actively monitor closed issues/PRs. |
When using @tailwindcss/postcss7-compat and jit, media queries are not generated.
The problem is that this chunk of code: https://github.com/postcss/postcss/blob/8.2.10/lib/node.js#L44-L48
is missing in postcss 7: https://github.com/postcss/postcss/blob/7.0.35/lib/node.es6#L37
Which means that the parent of the rule is not set correctly, which then causes this bug.
This fixes #4034.