Pass options when using addComponents and matchComponents
#14590
+48
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
force-pushed
the
fix/v4-components-apis
branch
from
6f701eb
to
3f96f00
Compare
philipp-spiess
approved these changes
Oct 9, 2024
|
@thecrypticace The PR description could use some updating but I see you already added a test :) |
thecrypticace
force-pushed
the
fix/v4-components-apis
branch
from
3f96f00
to
39425f4
Compare
RobinMalfait
force-pushed
the
fix/v4-components-apis
branch
from
39425f4
to
2b1bc2a
Compare
RobinMalfait
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We forgot to pass
optionsfromaddComponentstoaddUtilitiesand frommatchComponentstomatchUtilities.This didn't affect anything using addComponents but anything that used
matchComponentswouldn't have worked 😬