-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix class detection in Slim templates with attached attributes and IDs #14019
Conversation
Hello! Just wanted to let you know that by adding |
Yeah regex lookbehind wasn't supported until Safari 16.4 annoyingly which is why we don't use it (b/c CDN and Play). Won't matter in the future though. |
This PR brings back a tweaked version of our "inner matches" regex so the
m*-auto
classes in the following Slim template will be properly detected:The regex isn't identical to the previous one because we still want to prevent things like
px-1.5
from detecting bothpx-1
andpx-1.5
.Fixes #14013