-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spacing scale to min-width
, min-height
, and max-width
#12300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
added a commit
that referenced
this pull request
Dec 4, 2023
* Add spacing scale to `min-width`, `min-height`, and `max-width` * Update snapshots * Update changelog
thecrypticace
added a commit
that referenced
this pull request
Dec 5, 2023
* Add spacing scale to `min-width`, `min-height`, and `max-width` * Update snapshots * Update changelog
thecrypticace
added a commit
that referenced
this pull request
Dec 18, 2023
* Add spacing scale to `min-width`, `min-height`, and `max-width` * Update snapshots * Update changelog
18 tasks
babakfp
added a commit
to babakfp/tailwindcss-addons
that referenced
this pull request
Mar 4, 2024
This was referenced May 19, 2024
This was referenced Jul 27, 2024
This was referenced Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our
w-*
,h-*
, andmax-h-*
utilities all include our spacing scale which has various values across the range of 0–96 (from0rem
up to24rem
). However, our utilities formin-w-*
,min-h-*
, andmax-w-*
did not include these values. This leads to an inconsistent experience when using these utilities and this PR aims to fix those.Now you can write utilities like
min-w-32
,min-h-3
, ormax-w-48
and get the following as you would expect: