Update types to work with Node16 module resolution #12097
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node16
/NodeNext
module resolution in TypeScript now produces objects with a default key when usingexport default
.The "correct" way to type CJS in TypeScript is via
export = …
but the problem here is there is a significant number of random limitations on what works and what doesn't. For example, you have to use namespaces to export any times — BUT — you cannot directly export a type that wasn't created in the same file — and in some cases — in the namespace.Fixes #12092