Skip to content

Commit

Permalink
Add grow and shrink aliases (#5733)
Browse files Browse the repository at this point in the history
This adds `grow-*` and `shrink-*` utilities as aliases for `flex-grow-*` and `flex-shrink-*` since those names are unnecessarily verbose. We will stop documenting the long form ones and consider them deprecated.

```diff
- <div class="flex-grow-0 flex-shrink">
+ <div class="grow-0 shrink">
```
  • Loading branch information
adamwathan authored Oct 9, 2021
1 parent 6d04c2d commit d2b53cd
Show file tree
Hide file tree
Showing 5 changed files with 32 additions and 6 deletions.
10 changes: 8 additions & 2 deletions src/corePlugins.js
Original file line number Diff line number Diff line change
Expand Up @@ -645,8 +645,14 @@ export let corePlugins = {
maxWidth: createUtilityPlugin('maxWidth', [['max-w', ['maxWidth']]]),

flex: createUtilityPlugin('flex'),
flexShrink: createUtilityPlugin('flexShrink', [['flex-shrink', ['flex-shrink']]]),
flexGrow: createUtilityPlugin('flexGrow', [['flex-grow', ['flex-grow']]]),
flexShrink: createUtilityPlugin('flexShrink', [
['flex-shrink', ['flex-shrink']], // Deprecated
['shrink', ['flex-shrink']],
]),
flexGrow: createUtilityPlugin('flexGrow', [
['flex-grow', ['flex-grow']], // Deprecated
['grow', ['flex-grow']],
]),
flexBasis: createUtilityPlugin('flexBasis', [['basis', ['flex-basis']]]),

tableLayout: ({ addUtilities }) => {
Expand Down
6 changes: 6 additions & 0 deletions tests/arbitrary-values.test.css
Original file line number Diff line number Diff line change
Expand Up @@ -212,9 +212,15 @@
.flex-shrink-\[var\(--shrink\)\] {
flex-shrink: var(--shrink);
}
.shrink-\[var\(--shrink\)\] {
flex-shrink: var(--shrink);
}
.flex-grow-\[var\(--grow\)\] {
flex-grow: var(--grow);
}
.grow-\[var\(--grow\)\] {
flex-grow: var(--grow);
}
.basis-\[var\(--basis\)\] {
flex-basis: var(--basis);
}
Expand Down
2 changes: 2 additions & 0 deletions tests/arbitrary-values.test.html
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,9 @@

<div class="flex-[var(--flex)]"></div>
<div class="flex-shrink-[var(--shrink)]"></div>
<div class="shrink-[var(--shrink)]"></div>
<div class="flex-grow-[var(--grow)]"></div>
<div class="grow-[var(--grow)]"></div>
<div class="basis-[var(--basis)]"></div>

<div class="origin-[50px_50px]"></div>
Expand Down
12 changes: 12 additions & 0 deletions tests/basic-usage.test.css
Original file line number Diff line number Diff line change
Expand Up @@ -281,12 +281,24 @@
.flex-shrink-0 {
flex-shrink: 0;
}
.shrink {
flex-shrink: 1;
}
.shrink-0 {
flex-shrink: 0;
}
.flex-grow {
flex-grow: 1;
}
.flex-grow-0 {
flex-grow: 0;
}
.grow {
flex-grow: 1;
}
.grow-0 {
flex-grow: 0;
}
.basis-auto {
flex-basis: auto;
}
Expand Down
8 changes: 4 additions & 4 deletions tests/basic-usage.test.html
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,10 @@
<div class="fill-current"></div>
<div class="flex-1"></div>
<div class="flex-row-reverse"></div>
<div class="flex-grow"></div>
<div class="flex-grow-0"></div>
<div class="flex-shrink"></div>
<div class="flex-shrink-0"></div>
<div class="flex-grow flex-grow-0"></div>
<div class="grow grow-0"></div>
<div class="flex-shrink flex-shrink-0"></div>
<div class="shrink shrink-0"></div>
<div class="basis-auto basis-7"></div>
<div class="flex-wrap"></div>
<div class="float-right"></div>
Expand Down

0 comments on commit d2b53cd

Please sign in to comment.