Don't include .prose
in :where
pseudos
#352
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #351.
This PR changes the way we generate CSS for parts of the selector that start with a direct child combinator (
>
).Previously we'd generate a selector like this:
The problem is the
.prose
within the:where()
isn't replace if you@apply prose
, so the class where you're doing the@apply
doesn't actually behave the same as usingprose
directly in your markup.My instinct is that people just shouldn't do that but it's a fairly easy fix so whatever:
I'm somewhat suspicious that we didn't do this in the first place, so there might be a reason this doesn't actually work. Curious if @thecrypticace or @RobinMalfait can think of any reason this would be an issue.