Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix server not launching on older versions of VSCode #998

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

thecrypticace
Copy link
Contributor

Our use of isBuiltin does not work with VSCode < 1.78 and causes the server to not start. We have to use a different API for this when isBuiltin is not available.

Fixes #997

@thecrypticace thecrypticace changed the title Fix loading on old versions of VSCode Fix server not launching on older versions of VSCode Jun 27, 2024
@thecrypticace thecrypticace merged commit 413f4f1 into master Jun 27, 2024
@thecrypticace thecrypticace deleted the feat/old-vscode branch June 27, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension issue
1 participant