Show pixel equivalents in completions and hovers of the theme() helper
#935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This internal helper is what Tailwind uses to emit the value into the CSS.
RobinMalfait
approved these changes
Mar 26, 2024
There was a problem hiding this comment.
Looks good, I think only thing that comes to mind is that it's rather complex right now (but we can clean that up in separate PRs)
The other thing is that it would be nice to have a space between the value and the comment:
- 1.125rem/* 18px */
- 0.5rem/* 8px */
+ 1.125rem /* 18px */
+ 0.5rem /* 8px */
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
theme()helper we didn't transform values as Tailwind itself would when emitting into the CSS file. Now we do and also show pixel equivalents forremvalues.Before:
After:
Fixes #927