Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color format options (rgb, hex) #831

Merged

Conversation

flostellbrink
Copy link
Contributor

@flostellbrink flostellbrink commented Jul 20, 2023

Formats are displayed in completions and as comments in hovered css. This helps with comparing code to designs.

This is basically an up to date version of #416 and fixes #418.

Makes it trivial to add more color formats going forward if people need them.

Settings:

image

Completions:

image

Hovers:

image

@joaoprocopio
Copy link

I would absolutely LOVE this!

@flostellbrink
Copy link
Contributor Author

Any feedback would be much appreciated @bradlc!

@xsjcTony
Copy link

Any update? Bump. This is really needed feature.

@AlexF090
Copy link

AlexF090 commented Sep 11, 2023

image
I don't understand why this feature is shown here (README) even though it doesn't exist.
Or is there a hidden configuration option?

@numso
Copy link

numso commented Sep 23, 2023

I took the latest version (0.10.0) of this extension, applied this PR, and published it as a new vscode extension. I don't plan on maintaining it long term but my team couldn't wait any longer for this feature. Thought I'd post it here in case it helps anyone else.

https://marketplace.visualstudio.com/items?itemName=numso.vscode-tailwindcss-with-hex-colors

(aside: wouldn't it be amazing if you could use https://www.npmjs.com/package/patch-package on vscode extensions??)

@UNDERCOVERj
Copy link

mark

@Molunerfinn
Copy link

Very helpful

@Molunerfinn
Copy link

@thecrypticace Hope to merge this PR, it's very helpful

@GustavoSmith
Copy link

When will this be merged?

@federicocappellotto97
Copy link

+1, we need this please!!

@saymondamasio
Copy link

Someone merge the PR, please

@gustavo-mvp
Copy link

@flostellbrink resolve the conflicts please 🙏
UP!

@flostellbrink
Copy link
Contributor Author

Unfortunately a rebase is out of the questions at the moment. I need to test the changes, and master has been broken for three weeks straight now.

Either way I have no reason to believe anyone at tailwind actually wants this. Only leaving the PR open to avoid duplicate work.

Formats are displayed in completions and as comments in hovered css.
This helps with comparing code to designs.
@thecrypticace thecrypticace self-assigned this Feb 13, 2024
@thecrypticace
Copy link
Contributor

Hey, I'm going to be adding support for this but in a slightly different form. I think we can get rid of the color format option as well as simplify some things.

We're working on v4 right now but I expect I'll pick this back up possibly next week unless I happen to get to it sooner.

@thecrypticace thecrypticace merged commit 4b46fc5 into tailwindlabs:master Mar 11, 2024
@thecrypticace
Copy link
Contributor

This has been merged and should be available in the pre-release build shortly. Thanks!

luckasRanarison added a commit to luckasRanarison/tailwind-tools.nvim that referenced this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color Hex Code in intellisense box