Fallback to static chevron color if theme is using variables #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
philipp-spiess
approved these changes
Sep 5, 2024
This was referenced Sep 27, 2024
This was referenced Sep 28, 2024
This was referenced Oct 9, 2024
This was referenced Oct 16, 2024
This was referenced Oct 26, 2024
This was referenced Nov 2, 2024
This was referenced Nov 5, 2024
This was referenced Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now if your
gray.500color includes a CSS variable, the chevron on your select elements will disappear because URLs inbackground-imagecan't use CSS variables.This PR just ensures that if there's a variable in your color, we fallback to the default
gray.500so at least the chevron doesn't disappear.Fixes #165.