Add aria-orientation to the Listbox component
#683
Merged
+264
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). headlessui-vue – ./packages/@headlessui-vue🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-vue/HPtUjFkwVf9QsjH5mxzLkPjDeBqx headlessui-react – ./packages/@headlessui-react🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-react/ox4Dq1yHoBiAjVeLfrDaj1fEH4vq |
RobinMalfait
force-pushed
the
listbox-orientation
branch
from
1f89ceb to
7300c60
Compare
RobinMalfait
changed the title
aria-orientation to the Listbox componentaria-orientation to the Listbox component
By default the `Listbox` will have an orientation of `vertical`. When you pass the `horizontal` prop to the `Listbox` component then the `aria-orientation` will be set to `horizontal`. Additionally, we swap the previous/next keys: - Vertical: ArrowUp/ArrowDown - Horizontal: ArrowLeft/ArrowRight
RobinMalfait
force-pushed
the
listbox-orientation
branch
from
8c952a6 to
d3b5abf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the
Listboxwill have an orientation ofvertical. Whenyou pass the
horizontalprop to theListboxcomponent then thearia-orientationwill be set tohorizontal.Additionally, we swap the previous/next keys: