Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Vue reactivity & disabled prop #512

Merged
merged 4 commits into from
May 12, 2021
Merged

Conversation

RobinMalfait
Copy link
Member

In some places we were destructuring data from the incoming props. But this means that we also loose some reactivity along the way. This PR fixes that.

We also improved the disabled prop. It was failing because of 2 reasons:

  1. Because of the reactivity issue, we lost "updates" to this prop.
  2. We always had a tabindex: -1, but that is now conditionally applied based on the incoming disabled prop.

Fixes: #508
Fixes: #509
Fixes: #483

@vercel
Copy link

vercel bot commented May 12, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

headlessui-react – ./packages/@headlessui-react

🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-react/H1GWdg5ghFi2YqYsvyKVh37qrQR1
✅ Preview: https://headlessui-react-git-improve-vue-reactivity-tailwindlabs.vercel.app

headlessui-vue – ./packages/@headlessui-vue

🔍 Inspect: https://vercel.com/tailwindlabs/headlessui-vue/46FdzHvSLiri4iDBhCoP2ohAQeJR
✅ Preview: https://headlessui-vue-git-improve-vue-reactivity-tailwindlabs.vercel.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant