Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use React.JSX instead of JSX #3511

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

memark
Copy link
Contributor

@memark memark commented Oct 6, 2024

The global JSX type is deprecated in React 18.3 and removed in React 19 RC. This PR changes the code to use the supported React.JSX syntax instead.

PS. Would you accept a similar PR for 1.x? I personally haven't upgraded all my projects yet.

Copy link

vercel bot commented Oct 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
headlessui-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2024 6:42pm
headlessui-vue ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2024 6:42pm

Copy link
Member

@RobinMalfait RobinMalfait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful, thank you!

We used to support React 16, but since Headless UI v2, we rely on React 18 but haven't updated this yet. Thanks for doing this!

@memark
Copy link
Contributor Author

memark commented Nov 16, 2024

@RobinMalfait Follow-up question: Would you accept a similar PR for 1.x? I personally haven't upgraded all my projects yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants